Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed resolution of local file references ignoring files not named main.bicep #766

Merged
merged 81 commits into from
Jan 12, 2024
Merged

fix: Fixed resolution of local file references ignoring files not named main.bicep #766

merged 81 commits into from
Jan 12, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 4, 2024 •
edited
Loading

Description

Successful test with to-be VM module:
image

Pipeline
avm.res.api-management.service
avm.res.app.managed-environment
avm.res.automation.automation-account
avm.res.batch.batch-account
avm.res.cognitive-services.account
avm.res.compute.disk-encryption-set
avm.res.compute.gallery
avm.res.compute.proximity-placement-group
avm.res.compute.ssh-public-key
avm.res.compute.virtual-machine
avm.res.container-service.managed-cluster
avm.res.data-factory.factory
avm.res.db-for-postgre-sql.flexible-server
avm.res.document-db.database-account
avm.res.event-grid.domain
avm.res.event-grid.system-topic
avm.res.event-grid.topic
avm.res.insights.action-group
avm.res.insights.activity-log-alert
avm.res.insights.component
avm.res.insights.data-collection-endpoint
avm.res.insights.data-collection-rule
avm.res.insights.diagnostic-setting
avm.res.insights.metric-alert
avm.res.insights.scheduled-query-rule
avm.res.insights.webtest
avm.res.key-vault.vault
avm.res.kubernetes-configuration.extension
avm.res.kubernetes-configuration.flux-configuration
avm.res.logic.workflow
avm.res.maintenance.maintenance-configuration
avm.res.managed-identity.user-assigned-identity
avm.res.network.application-security-group
avm.res.network.bastion-host
avm.res.network.connection
avm.res.network.ddos-protection-plan
avm.res.network.dns-forwarding-ruleset
avm.res.network.dns-resolver
avm.res.network.dns-zone
avm.res.network.express-route-circuit
avm.res.network.express-route-gateway
avm.res.network.firewall-policy
avm.res.network.front-door-web-application-firewall-policy
avm.res.network.front-door
avm.res.network.load-balancer
avm.res.network.nat-gateways
avm.res.network.network-interface
avm.res.network.network-security-group
avm.res.network.private-dns-zone
avm.res.network.private-endpoint
avm.res.network.public-ip-address
avm.res.network.public-ip-prefix
avm.res.network.route-table
avm.res.network.trafficmanagerprofile
avm.res.network.virtual-network
avm.res.network.vpn-gateway
avm.res.network.vpn-site
avm.res.operational-insights.workspace
avm.res.operations-management.solution
avm.res.power-bi-dedicated.capacity
avm.res.resource-graph.query
avm.res.resources.deployment-script
avm.res.resources.resource-group
avm.res.search.search-service
avm.res.service-bus.namespace
avm.res.sql.server
avm.res.web.serverfarm
avm.res.web.static-site

AlexanderSehr and others added 30 commits November 7, 2023 22:23
@AlexanderSehr
Added skeleton
20ac8b7
@AlexanderSehr
Implemented first new tests
4939b4d
@AlexanderSehr
Changed to warning
4e1d86f
@AlexanderSehr
Expanded test verbosity & added additional tets
94fff0b
@AlexanderSehr
Finalized further tests
c18ce6b
@AlexanderSehr
Update to latest
a343694
@AlexanderSehr
Update to latest
3a6f0a2
@AlexanderSehr
Added module name + small fix
4ab6a5b
@AlexanderSehr
Fixed kvlt
9bb64bd
@AlexanderSehr
Small caching fix
68e2bd2
@AlexanderSehr
Small fix and enabled passthru of warnings to GH
1a013c2
@AlexanderSehr
More updates
1c2fc8a
@AlexanderSehr
Update to latest
d9c6dd5
@AlexanderSehr
Updated test names
dd0c343
@AlexanderSehr
JSON rollback
2ebd458
@AlexanderSehr
Updated regex
f6caf7e
@AlexanderSehr
Removed assertion
f56f66a
@AlexanderSehr
Update to latest
282b640
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
c025f52 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr @eriqua
Update avm/utilities/pipelines/staticValidation/compliance/module.tes…
405901a 
…ts.ps1

Co-authored-by: Erika Gressi <[email protected]>
@AlexanderSehr
Merge branch 'main' into users/alsehr/testFileCompliance
904c82f
@AlexanderSehr
Rollback of unrelated changes
ef24d1f
@AlexanderSehr
Merge branch 'Azure:main' into main
9393aa1
@AlexanderSehr
Merge branch 'Azure:main' into main
cb39086
@AlexanderSehr
Merge branch 'Azure:main' into main
89eac40
@AlexanderSehr
Merge branch 'Azure:main' into main
712a673
@AlexanderSehr
Resolved conflict
55e095f
@AlexanderSehr
Update to latest
3121335
@AlexanderSehr
Merge branch 'Azure:main' into main
e9d736c
@AlexanderSehr
Merge branch 'Azure:main' into main
abfa1b9
@AlexanderSehr AlexanderSehr added Bug Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 4, 2024
@AlexanderSehr AlexanderSehr linked an issue Jan 4, 2024 that may be closed by this pull request
[Bug Report]: AVM readme generator can't resolve external dependecies, if they are in sub-modules #764
Closed
@AlexanderSehr AlexanderSehr added the Type: Bug 🐛 Something isn't working label Jan 4, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review January 10, 2024 13:22
@AlexanderSehr AlexanderSehr requested review from a team as code owners January 10, 2024 13:22
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 10, 2024 13:22
rahalan
rahalan previously approved these changes Jan 10, 2024
View reviewed changes
eriqua
eriqua requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is updating utilities and will cause all pipelines to run, I'd kindly ask static validation run and badges for all modules

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner January 12, 2024 20:21
@AlexanderSehr
Copy link
Contributor Author

As this is updating utilities and will cause all pipelines to run, I'd kindly ask static validation run and badges for all modules

Done @eriqua. Added the fix for the Proximity Placement Group as it would otherwise fail the static tests.

@AlexanderSehr AlexanderSehr requested a review from eriqua January 12, 2024 20:26
eriqua
eriqua approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit bbd09c9 into Azure:main Jan 12, 2024
10 checks passed
@AlexanderSehr AlexanderSehr mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

@rahalan rahalan rahalan left review comments

Assignees

@AlexanderSehr AlexanderSehr

Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: AVM readme generator can't resolve external dependecies, if they are in sub-modules
3 participants
@AlexanderSehr @eriqua @rahalan